Add test fixtures demonstrating export statement validation bugs #75277

unstubbable · 2025-01-24T14:38:39Z

The issues with the current export statement validation for app router pages are documented in the added fixtures, see also the inline comments in the diff.

unstubbable · 2025-01-24T14:38:57Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-01-24T14:48:01Z

Failing test suites

Commit: 5e1b67f

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/development/app-dir/error-overlay/async-client-component/async-client-component.test.ts (PPR)

app-dir - async-client-component > app router client component async module

Expand output

● app-dir - async-client-component › app router client component async module

No Redbox to open.

  23 |     const browser = await next.browser('/client')
  24 |
> 25 |     await openRedbox(browser)
     |     ^
  26 |
  27 |     const description = await getRedboxDescription(browser)
  28 |     const componentStack = await getStackFramesContent(browser)

  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)

Cause:
elementHandle.click: Element is not attached to the DOM
Call log:
  - attempting click action
  -   waiting for element to be visible, enabled and stable

  394 |   click() {
  395 |     return this.chain((el: ElementHandleExt) => {
> 396 |       return el.click().then(() => el)
      |                 ^
  397 |     })
  398 |   }
  399 |

  at click (lib/browsers/playwright.ts:396:17)
  at openRedbox (lib/next-test-utils.ts:913:7)
  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:395:17)
  at click (lib/next-test-utils.ts:913:63)
  at Object.<anonymous> (development/app-dir/error-overlay/async-client-component/async-client-component.test.ts:25:5)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-01-24T14:52:56Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
buildDuration	19.1s	16.2s	N/A
buildDurationCached	15.4s	13.2s	N/A
nodeModulesSize	419 MB	419 MB	N/A
nextStartRea..uration (ms)	436ms	424ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
5306-HASH.js gzip	54.1 kB	54.1 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	34.6 kB	34.6 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
index.html gzip	523 B	523 B	✓
link.html gzip	538 B	539 B	N/A
withRouter.html gzip	518 B	521 B	N/A
Overall change	523 B	523 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	210 kB	210 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
middleware-b..fest.js gzip	669 B	666 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	378 kB	378 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	365 kB	365 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	27.7 kB	27.7 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.49 MB	2.49 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js hl/test-buggy-export-validations	Change
0.pack gzip	2.1 MB	2.1 MB	N/A
index.pack gzip	74.6 kB	74.9 kB	⚠️ +322 B
Overall change	74.6 kB	74.9 kB	⚠️ +322 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 2448396

unstubbable · 2025-01-24T15:15:11Z

crates/next-custom-transforms/tests/errors.rs

-#[fixture("tests/errors/react-server-components/client-graph/**/input.js")]
-fn react_server_components_client_graph_errors(input: PathBuf) {
+#[fixture("tests/errors/react-server-components/**/input.js")]
+fn react_server_components_errors(input: PathBuf) {


Fly-by refactor to combine the server-graph and client-graph tests. Their config is identical apart from is_react_server_layer, which we now derive from the input path, i.e. by checking whether server-graph is included in the path.

unstubbable · 2025-01-24T15:18:05Z

...t-custom-transforms/tests/errors/react-server-components/client-graph/multiple/output.stderr

This is completely off. getServerSideProps is logged twice with different messages (the first one being wrong), and the two metadata export messages are missing.

unstubbable · 2025-01-24T15:19:48Z

...custom-transforms/tests/errors/react-server-components/server-graph/dynamic-io/output.stderr

All five issues incorrectly report the revalidate export statement as the source instead of their respective statements. The order is also not as it occurs in the file.

The order of the reported issues is currently non-deterministic, which may lead to the react_server_components_errors_tests__errors__react_server_components__server_graph__dynamic_io__input_js test failing in CI. This will be fixed in the next PR in the stack.

unstubbable · 2025-01-24T15:20:40Z

...transforms/tests/errors/react-server-components/server-graph/metadata-conflict/output.stderr

This should ideally highlight both export statements.

Fixes all issues related to the current export statement validation for app router pages, as highlighted in #75277.

ijjk added created-by: Next.js team PRs by the Next.js team. Turbopack Related to Turbopack with Next.js. labels Jan 24, 2025

This was referenced Jan 24, 2025

Fix export statement validations for app router pages #75278

Merged

Emit build error when useCache is enabled and Edge runtime is used #75279

Merged

Add test fixtures demonstrating export statement validation bugs

2448396

unstubbable force-pushed the hl/test-buggy-export-validations branch from 5e1b67f to 2448396 Compare January 24, 2025 15:10

unstubbable commented Jan 24, 2025

View reviewed changes

unstubbable marked this pull request as ready for review January 24, 2025 15:38

ztanner approved these changes Jan 24, 2025

View reviewed changes

unstubbable merged commit 958b966 into canary Jan 24, 2025
130 of 132 checks passed

unstubbable deleted the hl/test-buggy-export-validations branch January 24, 2025 16:24

unstubbable added a commit that referenced this pull request Jan 24, 2025

Fix export statement validations for app router pages (#75278)

bc3e597

Fixes all issues related to the current export statement validation for app router pages, as highlighted in #75277.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test fixtures demonstrating export statement validation bugs #75277

Add test fixtures demonstrating export statement validation bugs #75277

unstubbable commented Jan 24, 2025 •

edited

Loading

unstubbable commented Jan 24, 2025 •

edited

Loading

ijjk commented Jan 24, 2025

ijjk commented Jan 24, 2025 •

edited

Loading

unstubbable Jan 24, 2025

unstubbable Jan 24, 2025

unstubbable Jan 24, 2025

unstubbable Jan 24, 2025

unstubbable Jan 24, 2025

Add test fixtures demonstrating export statement validation bugs #75277

Add test fixtures demonstrating export statement validation bugs #75277

Conversation

unstubbable commented Jan 24, 2025 • edited Loading

unstubbable commented Jan 24, 2025 • edited Loading

ijjk commented Jan 24, 2025

Failing test suites

ijjk commented Jan 24, 2025 • edited Loading

Stats from current PR

unstubbable Jan 24, 2025

Choose a reason for hiding this comment

unstubbable Jan 24, 2025

Choose a reason for hiding this comment

unstubbable Jan 24, 2025

Choose a reason for hiding this comment

unstubbable Jan 24, 2025

Choose a reason for hiding this comment

unstubbable Jan 24, 2025

Choose a reason for hiding this comment

unstubbable commented Jan 24, 2025 •

edited

Loading

unstubbable commented Jan 24, 2025 •

edited

Loading

ijjk commented Jan 24, 2025 •

edited

Loading