Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.3] Move all documentation examples to separate test files (#3055) #3132

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[Backport 1.3] Move all documentation examples to separate test files (#3055) #3132

merged 3 commits into from
Feb 11, 2025
+5,427 −1,577

Conversation

jbrinkman
Copy link
Collaborator

  • Backport documentation example PR from main to release 1.3.

Signed-off-by: Joseph Brinkman joe.brinkman@improving.com

Conflicts:

go/api/base_client.go

Issue link

This Pull Request is linked to issue (2828)

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jbrinkman
Move all documentation examples to separate test files (#3055)
d91ca9d 
* add initial framework examples

Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
Co-authored-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: jbrinkman <joe.brinkman@improving.com>

# Conflicts:
#	go/api/base_client.go
@jbrinkman jbrinkman added Feature Additional feature, big or small go golang wrapper labels Feb 11, 2025
@jbrinkman jbrinkman added this to the 1.3 milestone Feb 11, 2025
@jbrinkman jbrinkman requested a review from a team as a code owner February 11, 2025 16:30
@jbrinkman jbrinkman changed the title Move all documentation examples to separate test files (#3055) [Backport 1.3] Move all documentation examples to separate test files (#3055) Feb 11, 2025
@jbrinkman
update zinter changes in cherrypick
20fbad3 
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 80d97f7 into release-1.3 Feb 11, 2025
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/jbrinkman-doc-examples-cherrypick branch February 11, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
Feature Additional feature, big or small go golang wrapper
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrinkman @Yury-Fridlyand @yipin-chen