Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
jwt
lib fails on EdDSA jwts even though it doesn't verify the signature 😞This means switching to EDDSA HashJwts isn't possible for now; which is fine I can keep those as HS256 JWTs, but I want to fix this now so we can potentially switch it in the distant future if we have to :)
Plus this removes the dependency on
jwt
, which is probably good since we should be usingjose
for everything where possible.Implementation notes
Manually unpack and decode the jwt when reading HashJWTs rather than depending on the
jwt
lib.It's really easy to do, and it's part of the spec so it's not going to change.
Test coverage
Tested against Share's push/pull transcripts