Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard navigation for contenteditable elements #41157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohamadSalman11
Copy link
Contributor

Description

If the target is a contenteditable element, then there's no need to process the next steps like for input and textarea elements because it won't work correctly.And also event.preventDefault() will prevent moving up or down inside the editable content.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes Dropdown prevents default actions for contenteditable elements on Up/Down arrow keys #41021

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner January 17, 2025 14:23
@mdo mdo added this to v5.3.6 Apr 9, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 9, 2025
@mdo
Copy link
Member

mdo commented Apr 9, 2025

I think this checks out for me @julien-deramond—pretty focused fix for the linked issue.

@julien-deramond julien-deramond moved this from To do to Review in progress in v5.3.6 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

Dropdown prevents default actions for contenteditable elements on Up/Down arrow keys
2 participants