-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating labels: Fix max-width
and background-color
#39720
Conversation
max-width
max-width
and background-color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @louismaximepiton for this fix that LGTM!
I've added in this PR a new visual test because it's always challenging to gather all the different use cases along the way: 8a38e2b. We'll be able to add some other use cases if we can find other issues in the future :)
Locally:
npm run dist
# Then navigate to `file:///Users/xxxxx/twbs/bootstrap/js/tests/visual/floating-label.html`
Please note that it would be probably better at some point to do that with Storybook.
Based on these examples, the only minor improvement could be related to the following, where there's a small overlap between the long label and the invalid icon. But this could be tackled in another PR IMO:
@mdo, are you OK with this approach? If so, I'll merge it as is for a v5.3.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
Description
Add a
max-width
to label inside Floating labels. Reverting and upgrading a change inside #38313.Motivation & Context
Issue described in #39080.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #39080.
Might supersede #39480.