Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inheritance issues on border-width utilities #37999

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Avoid inheritance issues on border-width utilities #37999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f17df6
Avoid inheritance issues on border-width utilities
mdo Feb 4, 2023
46b8fcf
Add mention to migration guide
mdo Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scss/_utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ $utilities: map-merge(
values: $utilities-border-subtle
),
"border-width": (
css-var: true,
css-variable-name: border-width,
property: border-width,
// css-var: true,
// css-variable-name: border-width,
class: border,
values: $border-widths
),
Expand Down
2 changes: 2 additions & 0 deletions site/content/docs/5.3/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ If you're migrating from our previous alpha release of v5.3.0, please reviewing

- Added new link utilities for link color opacity, underline offset, underline color, and underline opacity. [Explore the new links utilities.]({{< docsref "/utilities/link" >}})

- CSS variable based `border-width` utilities have been reverted to set their property directly (as was done prior to v5.2.0). This avoids inheritance issues across nested elements, including tables.

### Docs

- Examples are now displayed with the appropriate light or dark color mode as dictated by the setting in our docs. However, they lack an individual color mode picker for the time being.
Expand Down