Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Tailscale) Update Tailscale HowTo for Talos #30925

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

itconstruct
Copy link
Contributor

Description

This PR is to update the Tailscale How To Guide for Talos OS and to remove TrueNAS specific components that are no longer relevant.

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

Documentation changes only

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • [x ] 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Added Tailscale DNS Setup for Talos in the Tailscale portal

Signed-off-by: Addison McDermid <admin@itconstruct.com.au>
Signed-off-by: Addison McDermid <admin@itconstruct.com.au>
itconstruct

This comment was marked as resolved.

Remove unrequired images
Add image for DNS Nameserver split DNS setup for Talos.
@itconstruct

This comment was marked as resolved.

Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be 100% perfect, but at least 100% better than referencing SCALE.
Thanks!

@PrivatePuffin PrivatePuffin merged commit 84e9531 into truecharts:master Jan 23, 2025
25 of 27 checks passed
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants