Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added minio standalone #1308

Merged
merged 14 commits into from
Nov 12, 2021
Merged

added minio standalone #1308

merged 14 commits into from
Nov 12, 2021

Conversation

ralphte
Copy link
Contributor

@ralphte ralphte commented Nov 11, 2021

Description
Add standalone minio app
Fixes #

Type of change

  • [ X] Feature/App addition

How Has This Been Tested?
Tested with Truenas scale.

PrivatePuffin
PrivatePuffin requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking quite good actually! :)

Please be aware that you don't need the md files, they are ALL automatically generated!

charts/incubator/minio/questions.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/questions.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/values.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/values.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/values.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/questions.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/minio/Chart.yaml Show resolved Hide resolved
charts/incubator/minio/Chart.yaml Outdated Show resolved Hide resolved
@PrivatePuffin
Copy link
Member

Why did you flag my review as "resolved" without pushing any changes?

@PrivatePuffin
Copy link
Member

Also small note:
If we add a form to a PR or issue, fill it in, don't delete the checklists.

ralphte and others added 5 commits November 11, 2021 18:56
@ralphte
Update charts/incubator/minio/Chart.yaml
382dde9 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/Chart.yaml
d2fb98d 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/Chart.yaml
941acfa 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/questions.yaml
e0f8fd6 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/values.yaml
002a516 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@PrivatePuffin
Copy link
Member

Awesome thanks for the push! 👍

ralphte and others added 3 commits November 11, 2021 18:57
@ralphte
Update charts/incubator/minio/values.yaml
44d2f05 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/questions.yaml
9ea58f2 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Update charts/incubator/minio/questions.yaml
a3fef38 
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@ralphte
Copy link
Contributor Author

ralphte commented Nov 12, 2021

Why did you flag my review as "resolved" without pushing any changes?

I guess I can't git very well. I Will work through these.

@PrivatePuffin
Copy link
Member

Why did you flag my review as "resolved" without pushing any changes?

I guess I can't git very well. I Will work through these.

uhmm you already just did?

@ralphte
Update values.yml
bd35896 
Add newline at EOF
@PrivatePuffin
Copy link
Member

Please helm-lint your stuff yourself and report when ready.

@PrivatePuffin
Copy link
Member

Running pre-commit also helps.

@ralphte
Copy link
Contributor Author

ralphte commented Nov 12, 2021

Please helm-lint your stuff yourself and report when ready.

No errors in lint

WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /Users/ralph/.kube/config
==> Linting .

1 chart(s) linted, 0 chart(s) failed```

@PrivatePuffin
Copy link
Member

Ok.
Please solve any CI issues when they show up!

@PrivatePuffin
Copy link
Member

PrivatePuffin commented Nov 12, 2021 •
edited
Loading

CAREFULLY read the errors and actually look at the code view where it is detected.

@PrivatePuffin PrivatePuffin merged commit 0acae00 into truecharts:master Nov 12, 2021
@PrivatePuffin
Copy link
Member

@all-contributors please add @ralphte for code

@allcontributors allcontributors bot mentioned this pull request Nov 19, 2021
Merged
@allcontributors
Copy link
Contributor

@Ornias1993

I've put up a pull request to add @ralphte! 🎉

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PrivatePuffin PrivatePuffin PrivatePuffin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralphte @PrivatePuffin @truecharts-admin