Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow double bracket initialization #162

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Disallow double bracket initialization #162

merged 1 commit into from
Jan 17, 2024

Conversation

willmostly
Copy link
Contributor

@willmostly willmostly commented Jan 16, 2024 •
edited by ebyhr
Loading

Fixes #155.

@cla-bot cla-bot bot added the cla-signed label Jan 16, 2024
@willmostly willmostly mentioned this pull request Jan 16, 2024
Closed
mosabua
mosabua approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at first glance.

@mosabua
Copy link
Member

mosabua commented Jan 16, 2024 •
edited
Loading

Any suggestions or objections @ebyhr ?

@willmostly willmostly force-pushed the disallow-double-brace-initialization branch from 556f624 to 10fec37 Compare January 17, 2024 17:18
@ebyhr ebyhr merged commit 4db8669 into trinodb:main Jan 17, 2024
@mosabua mosabua mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce ErrorProne DoubleBraceInitialization
3 participants
@willmostly @mosabua @ebyhr