-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update parameters in search API route to match search function parameters order #528
Conversation
…y for handling SearchType through the chain
….py for handling SearchType through the chain.
WalkthroughThis pull request modifies the search functionality in the API and search modules. The Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant R as API Router
participant S as Search Module
C->>R: POST /search {query, search_type}
R->>R: Create SearchPayloadDTO with search_type
R->>S: cognee_search(query_text=payload.query, query_type=payload.search_type, user=user)
S->>S: Validate query_type as SearchType
S-->>R: Return search results or error
R-->>C: Send response
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (16)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Updated handling of SearchType through the chain:
Router receives JSON with searchType Enum, example: "searchType": "CHUNKS"
FastAPI converts to SearchType enum via SearchPayloadDTO
search_v2.py expects SearchType enum
search.py takes SearchType enum and extracts value
log_query.py takes string value
Query model stores string in database
get_search_router.py
Matched the exact field name from JSON payload searchType instead of search_type in the SearchPayloadDTO class.
Changed cognee_search() params to use payload.query and payload.searchType
search.py
Changed query_type to SearchType
log_query to accept query_type.value parameter instead of str(query_type)
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin
Summary by CodeRabbit