feat: Support formatting hex/oct/bin integers #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods that create `Formatted<i64>` in hexadecimal, octal, and binary representation. In accordance with TOML 1.0 spec, these forms can be created only if the integer is nonnegative. For hexadecimal, it is possible to create either uppercase or lowercase representation. This commit does not change the AST and should be fully backwards- compatible.
pastelmind
force-pushed
the
integer-format
branch
from
f041dc1 to
a177d95
Compare
|
There is a lot of design discussion to be had on this. My general stance is PRs is for implementation discussion and all design discussion should be done in issues. Since #812 has been created, I'd recommend pushing the discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods that create
Formatted<i64>in hexadecimal, octal, and binary representations. In accordance with TOML 1.0 spec, these forms can be created only if the integer is nonnegative. For hexadecimal, it is possible to create both uppercase or lowercase representation.This PR does not change the AST and should be fully backwards-compatible.
Note: See #781 (reply in thread) for the discussion leading up to this PR. This approach is much more conservative than my initial attempts to create a new
Integertype that manages the current representation (hex/oct/bin). However, said approach was brittle: it wasn't clear how to classify mixed-case hexadecimals (0xabCDef), or hexadecimals with no alphabets (0x1234). I eventually realized that this was a formatting problem and that adding custom constructors forFormatted<i64>would suffice.