Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add request id on cluster event #9998

Merged

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Feb 6, 2025

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Feb 6, 2025
Copy link
Contributor Author

fengmk2 commented Feb 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 requested review from Brooooooklyn, darkskygit, forehalo and a team February 6, 2025 14:14
@fengmk2 fengmk2 marked this pull request as ready for review February 6, 2025 14:15
@graphite-app graphite-app bot requested a review from a team February 6, 2025 14:15
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.64%. Comparing base (891d9df) to head (1e83a05).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/base/event/eventbus.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9998      +/-   ##
==========================================
- Coverage   53.66%   53.64%   -0.03%     
==========================================
  Files        2267     2267              
  Lines      104128   104141      +13     
  Branches    17259    17262       +3     
==========================================
- Hits        55884    55864      -20     
- Misses      46880    46912      +32     
- Partials     1364     1365       +1     
Flag Coverage Δ
server-test 77.56% <91.30%> (-0.07%) ⬇️
unittest 31.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 force-pushed the 02-06-feat_server_add_request_id_on_cluster_event branch from a124dae to 73f94f2 Compare February 6, 2025 14:36
Copy link

graphite-app bot commented Feb 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-06-feat_server_add_request_id_on_cluster_event branch from 73f94f2 to 1e83a05 Compare February 7, 2025 02:06
@graphite-app graphite-app bot merged commit 1e83a05 into canary Feb 7, 2025
64 checks passed
@graphite-app graphite-app bot deleted the 02-06-feat_server_add_request_id_on_cluster_event branch February 7, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants