-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): client version check #9205
base: canary
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ea6742. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9205 +/- ##
===========================================
- Coverage 53.69% 41.43% -12.26%
===========================================
Files 2288 1986 -302
Lines 104679 69780 -34899
Branches 17424 15364 -2060
===========================================
- Hits 56203 28911 -27292
+ Misses 47108 39016 -8092
- Partials 1368 1853 +485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests
1e876b8
to
6de0745
Compare
eb7c0a5
to
6a54784
Compare
12b06fa
to
f95fbe9
Compare
} | ||
} | ||
|
||
async checkVersion(clientVersion?: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need the channel control, cross channel connections should be forbidden
f91d9a2
to
fae6343
Compare
7944cb8
to
d515b3b
Compare
d515b3b
to
2d14812
Compare
b1e0ba5
to
1cc988d
Compare
No description provided.