add finalizer to eks resource and use secret to store secretKey/secretId #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaolingxie
force-pushed
the
fix/add-finalizer-to-eks-resources
branch
4 times, most recently
from
0802a29 to
d1e5f49
Compare
…er to all resources. 2.store secretKey and secretId to secret and get project secret as env
shaolingxie
force-pushed
the
fix/add-finalizer-to-eks-resources
branch
from
d1e5f49 to
38103e3
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.to prevent accidental deletion, add cloud.tencent.com/eklet finalizer to all resources.
2.store secretKey and secretId to secret and get project secret as env