Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add finalizer to eks resource and use secret to store secretKey/secretId #135

Merged

Conversation

shaolingxie
Copy link

@shaolingxie shaolingxie commented Mar 5, 2025

1.to prevent accidental deletion, add cloud.tencent.com/eklet finalizer to all resources.
2.store secretKey and secretId to secret and get project secret as env

@shaolingxie shaolingxie force-pushed the fix/add-finalizer-to-eks-resources branch 4 times, most recently from 0802a29 to d1e5f49 Compare March 7, 2025 02:55
…er to all resources.

2.store secretKey and secretId to secret and get project secret as env
@shaolingxie shaolingxie force-pushed the fix/add-finalizer-to-eks-resources branch from d1e5f49 to 38103e3 Compare March 7, 2025 02:58
@Shangru-WU
Copy link
Contributor

lgtm

@huxiaoliang huxiaoliang merged commit 3ebd980 into tkestack:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants