New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump level of panel grid blanknness in `theme_classic()` #6321

Open

teunbrand wants to merge 2 commits into tidyverse:main from teunbrand:theme_classic_grid

Collaborator

teunbrand commented Feb 5, 2025

This PR aims to fix #6320.

Instead of setting panel.grid.major and panel.grid.minor to blank, we set the parent panel.grid to blank.

Reprex from issue:

devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2

p <- ggplot(mpg, aes(displ, hwy)) +
  geom_point() +
  theme_classic()

p + theme(panel.grid = element_line(colour = "limegreen"))

^{Created on 2025-02-05 with reprex v2.1.1}

teunbrand added 2 commits

February 5, 2025 10:41


          use grid parent element to invoke blank element

bc654a9


          Tweak bullet with related changes

f208661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet