JUnitXMLReporter does not synchronize the two synchronized collections when iterating #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeust
added a commit
that referenced
this pull request
Oct 19, 2015
…on_17 JUnitXMLReporter does not synchronize the two synchronized collections when iterating
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lines 177 and 180 of JUnitXMLReporter, synchronized collections m_configIssues and m_allTests
are both iterated in an unsynchronized manner, but according to Oracle Java 7 API specification
(http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedList(java.util.List)),
although a synchronizedList is thread-safe for list manipulations like insertion and deletion,
manual synchronization is required when the collection is iterated.
Failure to do so might result in non-deterministic behavior.
This pull request adds a fix by synchronizing m_configIssues and m_allTests when iterating.