-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make default metadata, labels and tags optional #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default metadata, labels and tags optional #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevang Please update this in the configuration in autogen/
then use make generate
.
Thanks @morgante, I updated it (not sure if I needed to reformat the generated files, cause is seems that a couple of lines have changed and the build is failing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests/linting is failing. Can you make sure they pass locally?
I reformatted and the linting tests all pass, yet I still get |
@kevang Looks like the linters are passing now, just waiting for integration tests to pass before merging. |
@morgante do you think that it's ok to merge now that the checks have passed? 🙂 |
SUMMARY
A number of default tags, metadata and labels are added to the nodepools by the different modules. This is fine when creating a new nodepool, but can be problematic when importing an existing nodepool that does not have those, as a new plan will lead to nodepool recreation, for example:
PROPOSED CHANGE
The proposed change makes it possible to use the modules with existing gke clusters/nodepools. It's not introducing any breaking changes and was tested with the beta private cluster. I'm happy to update the other modules, if you think the change makes sense.