-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add configuration flag for #141 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not do this directly in this file. Please transfer your changes to the autogen/cluster_regional.tf template. The same is related to all changes that are connected to the resources that are present in autogen folder. The changes from this folder are propagated to all places where they are used.
Your lint tests failed because you should have executed 2 commands before commit: |
Please also don't forget to add the tests that validate that your feature is present in the newly created cluster. |
@alexkonkin Thank you! |
|
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the suggested changes, run make generate && make generate_docs
, and then commit the changes.
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Co-Authored-By: Aaron Lane <aarondrewlane@gmail.com>
Quoting the results of the integration-tests execution: It seems that some resources have not been deleted after the previous CI execution.... |
I manually verified the node pool suite; the failure is unrelated to these changes. |
added enable_binary_authorization flag