Emits billable action metric for UpdateWorkflowExecutionOptions; fixes action metric for StartWorkflowExecution #7552
+27
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu/add_update_workflow_execution_opts_grpc_action
yiminc
reviewed
Apr 1, 2025
Comment on lines
-258
to
-265
| case startWorkflowExecution: | ||
| resp, ok := result.(*workflowservice.StartWorkflowExecutionResponse) | ||
| if !ok { | ||
| return | ||
| } | ||
| if resp.Started { | ||
| metrics.ActionCounter.With(metricsHandler).Record(1, metrics.ActionType("grpc_"+methodName)) | ||
| } |
There was a problem hiding this comment.
yes, this aligns with the documentation changes that I shared yesterday. we charge startworkflowexecution in cloud even if wf is already started
yiminc
approved these changes
Apr 1, 2025
stephanos
approved these changes
Apr 1, 2025
mastermanu
deleted the
manu/add_update_workflow_execution_opts_grpc_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.