CHASM: include library name in fully qualified component/task type name #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/chasm-rc-type
branch
from
802d6a7 to
5ca9dff
Compare
yycptt
reviewed
Apr 1, 2025
chasm/library.go
Outdated
Comment on lines
41
to
43
| Namer interface { | ||
| Name() string | ||
| } |
There was a problem hiding this comment.
Can we merge this interface back to Library? I think developer will be quite confused why it has a separate definition, but only used by Library.
chasm/registrable_component.go
Outdated
Comment on lines
81
to
89
| // Type returns the fully qualified name of the component, which is a combination of | ||
| // the library name and the component type. This is used to uniquely identify | ||
| // the component in the registry. | ||
| func (rc RegistrableComponent) Type() string { | ||
| return rc.componentType | ||
| if rc.library == nil { | ||
| // this should never happen because the component is only accessible from the library. | ||
| panic("component is not registered to a library") | ||
| } | ||
| return fullyQualifiedName(rc.library.Name(), rc.componentType) |
There was a problem hiding this comment.
let's make this method private for now. I don't think component developers needs to get the fully qualified name.
yycptt
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
CHASM: include library name in fully qualified component/task type name.
Why?
Type of
RegistrableComponentis stored insideChasmNode.Metadataand required to look up go type for proper deserialization. Therefore returned value must be fully qualified type name, not just type name.How did you test it?
Modified existing unit tests.
Potential risks
No risks.
Documentation
No.
Is hotfix candidate?
No.