CHASM: Get Component & Context implementation #7530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Mar 25, 2025
| return componentValue, nil | ||
| } | ||
|
|
||
| func (n *Node) prepareComponentValue( |
There was a problem hiding this comment.
This method or at least some part of it can be reused by Field.Get() implementation I think. cc @alexshtin
lina-temporal
approved these changes
Mar 26, 2025
yycptt
force-pushed
the
chasm-get-component
branch
from
9dbb7eb to
67c734c
Compare
yycptt
changed the title
yycptt
commented
Mar 31, 2025
| @@ -107,7 +107,7 @@ func testComponentSerializedNodes() map[string]*persistencespb.ChasmNode { | |||
| }, | |||
| Attributes: &persistencespb.ChasmNodeMetadata_ComponentAttributes{ | |||
| ComponentAttributes: &persistencespb.ChasmComponentAttributes{ | |||
| Type: "test_component", | |||
| Type: "TestLibrary.test_component", | |||
There was a problem hiding this comment.
@alexshtin Is this the right place to change? I don't see generateMapInit setting the Type field or probably I missed it.
alexshtin
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?