Let REM and ' signify comment line when at beginning of line #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telnet23
reviewed
Feb 1, 2023
Allows for midline `: REM`-style comments
Identifies a variety of REM and single-quote comment styles
lildude
reviewed
Feb 21, 2023
| @@ -26,7 +26,7 @@ patterns: [ | |||
| } | |||
| { | |||
| # comment | |||
| match: '(?i:REM.*)' | |||
| match: '(?i:\bREM\b.*|^'.*| '.*)' | |||
There was a problem hiding this comment.
👋 from github/linguist which uses this grammar for highlighting BASIC files on GitHub.com.
This PR introduces a typo which causes our grammar compiler to fail because the new ' chars here aren't escaped which makes this an invalid CSON grammar file.
This should probably be match: '(?i:\bREM\b.*|^\'.*| \'.*)'
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
REMkeyword creates comment-style highlighting even when in the middle of a line.Additionally, the single quote mark
'is not interpreted as an alternative syntax forREM.This change seeks to address both issues. Please have a look and see if this change is satisfactory. Thank you!
Current behavior of BASIC code block as rendered in GitHub Markdown:
