Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark body and fault as optional in output soap classes #1099

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Dec 1, 2024

📒 Description

The generator creates soap envelop classes where both body and fault are mandatory, they should both be optional

Resolves #1093

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarqubecloud bot commented Dec 1, 2024

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (95755fe) to head (31c22a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1099      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files          115      115              
  Lines         9281     9283       +2     
  Branches      1418     1419       +1     
===========================================
- Hits          9281     9260      -21     
- Misses           0       19      +19     
- Partials         0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit cd707c8 into main Dec 1, 2024
13 of 14 checks passed
@tefra tefra deleted the fix-1093 branch December 1, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOAP Body sometimes generated with mandatory fault field
1 participant