Remove unused code and unnecessary else branches
#57897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
requested review from
lyrixx,
welcoMattic,
chalasr,
dunglas,
OskarStark,
xabbuh and
yceruto
as code owners
alexandre-daubois
force-pushed
the
unecessary-local-vars
branch
from
a2026cd to
302e2bf
Compare
derrabus
reviewed
Jul 31, 2024
alexandre-daubois
force-pushed
the
unecessary-local-vars
branch
from
302e2bf to
a08df10
Compare
src/Symfony/Bridge/PsrHttpMessage/Factory/HttpFoundationFactory.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
unecessary-local-vars
branch
from
a08df10 to
1203390
Compare
xabbuh
approved these changes
Aug 2, 2024
OskarStark
approved these changes
Aug 2, 2024
fabpot
approved these changes
Aug 4, 2024
|
Thank you @alexandre-daubois. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2024
This PR was merged into the 7.2 branch. Discussion ---------- Various CS fix for consistency | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT A few fixes to match the rest of the codebase: - Remove useless `else` branches (as done in #57897) - Instantiating anonymous classes should not be followed by parentheses - An attribute without args should not be followed by parentheses Commits ------- 7558269 Various CS fix for consistency
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Oct 6, 2024
This PR was merged into the 7.2 branch. Discussion ---------- Various CS fix for consistency | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT A few fixes to match the rest of the codebase: - Remove useless `else` branches (as done in symfony/symfony#57897) - Instantiating anonymous classes should not be followed by parentheses - An attribute without args should not be followed by parentheses Commits ------- 75582694ec Various CS fix for consistency
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Oct 6, 2024
This PR was merged into the 7.2 branch. Discussion ---------- Various CS fix for consistency | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT A few fixes to match the rest of the codebase: - Remove useless `else` branches (as done in symfony/symfony#57897) - Instantiating anonymous classes should not be followed by parentheses - An attribute without args should not be followed by parentheses Commits ------- 75582694ec Various CS fix for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continueandreturnstatementselsewhere possible