Add types to public and protected properties

[nicolas-grekas]

Q	A
Branch?	7.0
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

🥵

Allowed by #45360

Follows #51068 and #51067

[derrabus]

Reviewing this PR is exhausting. I've reviewed up to the HttpFoundation component and will take a break now. 😓

[nicolas-grekas]

PR is ready for review. Needs #51121 to be 🍏

[derrabus]

The return type of end() is wider. My gut feeling is that they should match.

[nicolas-grekas]

All those classes in the return type of end() implement NodeParentInterface so we could reduce this to only it. I suppose the list is here to hint the IDE for autocompletion. Maybe we should keep only NodeParentInterface as native type and use @return for the rest?

The other strange thing is about the need to add NodeInterface to make this code work:

symfony/src/Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php

Lines 352 to 361 in 1935af6

	$node = new ArrayNode($this->name, $this->parent, $this->pathSeparator);
	$this->validateConcreteNode($node);
	$node->setAddIfNotSet($this->addDefaults);
	foreach ($this->children as $child) {
	$child->parent = $node;
	$node->addChild($child->getNode());
	}

end() can't return an ArrayNode because of its return type. Either the return type is wrong, or what?
Up to investigate and fix this on a lower branch?

[derrabus]

All those classes in the return type of end() implement NodeParentInterface so we could reduce this to only it. I suppose the list is here to hint the IDE for autocompletion. Maybe we should keep only NodeParentInterface as native type and use @return for the rest?

Would work for me to unblock the PR.

Up to investigate and fix this on a lower branch?

Maybe, but not right away. 🙈

[nicolas-grekas]

use @return for the rest

PR updated