-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use @clack/prompts #9219
feat: use @clack/prompts #9219
Conversation
Is there a way to test this locally and see what the new experience is like? |
yes, just run ../kit/packages/create-svelte/bin.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change! The "select what you want" for the optional things instead of a chain of yes/no is better, even if it requires some unlearning for existing users.
Is there anything fancy we want to add while we're at it? Ascii-Svelte-logo or sth like that.
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
I thought about it but it feels a bit gimmicky and doesn't work with very narrow terminals — I think we should respect the user's screen real estate as well as their time by making everything as compact and direct as possible |
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ok, I found it out. You need to press the space to select it. |
@shinokada Literally tracked down this PR to ask about this as well :) Definetly needs more clear instruction here @Rich-Harris |
Thought I'd have a go at using
@clack/prompts
to make thecreate-svelte
experience slightly more polished.Before:
After: