-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app.html
doesn't respect base path setting
#2852
Comments
Have you find a workaround around this? I have the base path in the html but it's a bit messy to change it when deploying... |
Other than the |
Is this something that should be addressed before 1.0 @benmccann ? |
I upgraded SvelteKit to Setting |
seems we suffer from the same issue: sveltejs/kit#2852 (comment)
Meanwhile the generated app.html uses: <link rel="icon" href="%svelte.assets%/favicon.png" /> which initially resolved the issue. |
Describe the bug
The skeleton template creates an
app.html
file that contains:Setting a base path using this setting breaks the favicon because it's hardcoded to use the root path (
https://mysite.com/favicon.png
), not the base (https://mysite.com/foo/favicon.png
).This is even more troublesome after adding a global stylesheet. The only alternative I've found is adding the stylesheet in
<svelte:head>
which is far from ideal.I couldn't find documentation for
%svelte.head%
or%svelte.body%
, but I think it would useful to have something like those that could access the config's base path value.Reproduction
https://github.com/sveltejs/kit
Logs
No response
System Info
System: OS: Linux 5.13 Pop!_OS 21.04 CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz Memory: 985.59 MB / 23.33 GB Container: Yes Shell: 3.3.0 - /usr/bin/fish Binaries: Node: 14.17.0 - /usr/local/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 8.1.1 - /usr/local/bin/npm Browsers: Firefox: 94.0
The text was updated successfully, but these errors were encountered: