Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(backend) search users #79

Merged
merged 3 commits into from
May 31, 2024
Merged

✨(backend) search users #79

merged 3 commits into from
May 31, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented May 29, 2024

Purpose

We need to be able to research users to invite them.
This PR add the route GET /api/v1.0/users/.
2 query params are available:

  • q to search on email field
  • document_id to exclude user that have access to a document_id

Proposal

  • add the GET /api/v1.0/users/
  • change user serializer to get the email field
  • fix CI backend linter

@AntoLC AntoLC self-assigned this May 29, 2024
@AntoLC AntoLC force-pushed the backend/search_users branch from 7f137da to dbdf194 Compare May 29, 2024 19:39
@AntoLC AntoLC added enhancement New feature or request backend labels May 29, 2024
@AntoLC AntoLC force-pushed the backend/search_users branch 2 times, most recently from 266d533 to e9f8d38 Compare May 29, 2024 20:13
@AntoLC AntoLC marked this pull request as ready for review May 29, 2024 20:16
@AntoLC AntoLC requested a review from sampaccoud May 29, 2024 20:16
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Should put it in the 0001_initial maybe?

@AntoLC AntoLC force-pushed the backend/search_users branch 2 times, most recently from 3ea9450 to 36186d7 Compare May 31, 2024 07:23
@AntoLC AntoLC enabled auto-merge (rebase) May 31, 2024 07:23
@AntoLC AntoLC disabled auto-merge May 31, 2024 07:28
AntoLC added 3 commits May 31, 2024 09:31
We need to search users by their email.
For that we will use the trigram similarity algorithm
provided by PostgreSQL. To use it we have to
activate the pg_trgm extension in postgres db.
To query the email we will use the query param
`q`.
We have another query param `document_id`, it is
necessary to exclude the users that have already
access to the document.
Change the field displayed on the users endpoint.
We need the email field to be displayed.
The linter in the CI was checking only the
impress directory. We were passing near some lint
issues. Now the linter checks the whole backend
directory.
@AntoLC AntoLC force-pushed the backend/search_users branch from 36186d7 to 93f6e56 Compare May 31, 2024 07:32
@AntoLC AntoLC enabled auto-merge (rebase) May 31, 2024 07:32
@AntoLC AntoLC merged commit f1227ed into main May 31, 2024
16 of 17 checks passed
@AntoLC AntoLC deleted the backend/search_users branch May 31, 2024 08:12
@AntoLC AntoLC linked an issue Jun 12, 2024 that may be closed by this pull request
AntoLC added a commit that referenced this pull request Jul 2, 2024
Added:
- Manage the document's right (#75)
- Update document (#68)
- Remove document (#68)
- (docker) dockerize dev frontend (#63)
- (backend) list users with email filtering (#79)
- (frontend) add user to a document (#52)
- (frontend) invite user to a document (#52)
- (frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- (frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- (frontend) Add beta tag on logo (#121)

Changed:
- Change site from Impress to Docs (#76)
- Generate PDF from a modal (#68)
- 🔧 (helm) sticky session by request_uri for signaling server (#78)
- (frontend) change logo (#84)
- (frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- Fix the break line when generate PDF (#84)

Delete:
- Remove trigger workflow on push tags on CI (#68)
- (frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 2, 2024
Added:
- Manage the document's right (#75)
- Update document (#68)
- Remove document (#68)
- (docker) dockerize dev frontend (#63)
- (backend) list users with email filtering (#79)
- (frontend) add user to a document (#52)
- (frontend) invite user to a document (#52)
- (frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- (frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- (frontend) Add beta tag on logo (#121)

Changed:
- Change site from Impress to Docs (#76)
- Generate PDF from a modal (#68)
- 🔧 (helm) sticky session by request_uri for signaling server (#78)
- (frontend) change logo (#84)
- (frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- Fix the break line when generate PDF (#84)

Delete:
- Remove trigger workflow on push tags on CI (#68)
- (frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- Manage the document's right (#75)
- Update document (#68)
- Remove document (#68)
- (docker) dockerize dev frontend (#63)
- (backend) list users with email filtering (#79)
- (frontend) add user to a document (#52)
- (frontend) invite user to a document (#52)
- (frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- (frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- (frontend) Add beta tag on logo (#121)

Changed:
- Change site from Impress to Docs (#76)
- Generate PDF from a modal (#68)
- 🔧 (helm) sticky session by request_uri for signaling server (#78)
- (frontend) change logo (#84)
- (frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- Fix the break line when generate PDF (#84)

Delete:
- Remove trigger workflow on push tags on CI (#68)
- (frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- Manage the document's right (#75)
- Update document (#68)
- Remove document (#68)
- (docker) dockerize dev frontend (#63)
- (backend) list users with email filtering (#79)
- (frontend) add user to a document (#52)
- (frontend) invite user to a document (#52)
- (frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- (frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- (frontend) Add beta tag on logo (#121)

Changed:
- Change site from Impress to Docs (#76)
- Generate PDF from a modal (#68)
- 🔧 (helm) sticky session by request_uri for signaling server (#78)
- (frontend) change logo (#84)
- (frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- Fix the break line when generate PDF (#84)

Delete:
- Remove trigger workflow on push tags on CI (#68)
- (frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- 🛂(frontend) Manage the document's right (#75)
- ✨(frontend) Update document (#68)
- ✨(frontend) Remove document (#68)
- 🐳(docker) dockerize dev frontend (#63)
- 👔(backend) list users with email filtering (#79)
- ✨(frontend) add user to a document (#52)
- ✨(frontend) invite user to a document (#52)
- 🛂(frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- 🌐(frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- ⚗️(frontend) Add beta tag on logo (#121)

Changed:
- ♻️(frontend) Change site from Impress to Docs (#76)
- ✨(frontend) Generate PDF from a modal (#68)
- 🔧(helm) sticky session by request_uri for signaling server (#78)
- ♻️(frontend) change logo (#84)
- ♻️(frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- 🐛(frontend) Fix the break line when generate PDF (#84)

Delete:
- 💚(CI) Remove trigger workflow on push tags on CI (#68)
- 🔥(frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- 🛂(frontend) Manage the document's right (#75)
- ✨(frontend) Update document (#68)
- ✨(frontend) Remove document (#68)
- 🐳(docker) dockerize dev frontend (#63)
- 👔(backend) list users with email filtering (#79)
- ✨(frontend) add user to a document (#52)
- ✨(frontend) invite user to a document (#52)
- 🛂(frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- 🌐(frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- ⚗️(frontend) Add beta tag on logo (#121)

Changed:
- ♻️(frontend) Change site from Impress to Docs (#76)
- ✨(frontend) Generate PDF from a modal (#68)
- 🔧(helm) sticky session by request_uri for signaling server (#78)
- ♻️(frontend) change logo (#84)
- ♻️(frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- 🐛(frontend) Fix the break line when generate PDF (#84)

Delete:
- 💚(CI) Remove trigger workflow on push tags on CI (#68)
- 🔥(frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- 🛂(frontend) Manage the document's right (#75)
- ✨(frontend) Update document (#68)
- ✨(frontend) Remove document (#68)
- 🐳(docker) dockerize dev frontend (#63)
- 👔(backend) list users with email filtering (#79)
- ✨(frontend) add user to a document (#52)
- ✨(frontend) invite user to a document (#52)
- 🛂(frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- 🌐(frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- ⚗️(frontend) Add beta tag on logo (#121)

Changed:
- ♻️(frontend) Change site from Impress to Docs (#76)
- ✨(frontend) Generate PDF from a modal (#68)
- 🔧(helm) sticky session by request_uri for signaling server (#78)
- ♻️(frontend) change logo (#84)
- ♻️(frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- 🐛(frontend) Fix the break line when generate PDF (#84)

Delete:
- 💚(CI) Remove trigger workflow on push tags on CI (#68)
- 🔥(frontend) Remove coming soon page (#121)
AntoLC added a commit that referenced this pull request Jul 3, 2024
Added:
- 🛂(frontend) Manage the document's right (#75)
- ✨(frontend) Update document (#68)
- ✨(frontend) Remove document (#68)
- 🐳(docker) dockerize dev frontend (#63)
- 👔(backend) list users with email filtering (#79)
- ✨(frontend) add user to a document (#52)
- ✨(frontend) invite user to a document (#52)
- 🛂(frontend) manage members (update role / list / remove) (#81)
- ✨(frontend) offline mode (#88)
- 🌐(frontend) translate cgu (#83)
- ✨(service-worker) offline doc management (#94)
- ⚗️(frontend) Add beta tag on logo (#121)

Changed:
- ♻️(frontend) Change site from Impress to Docs (#76)
- ✨(frontend) Generate PDF from a modal (#68)
- 🔧(helm) sticky session by request_uri for signaling server (#78)
- ♻️(frontend) change logo (#84)
- ♻️(frontend) pdf has title doc (#84)
- ⚡️(e2e) unique login between tests (#80)
- ⚡️(CI) improve e2e job (#86)
- ♻️(frontend) improve the error and message info ui (#93)
- ✏️(frontend) change all occurences of pad to doc (#99)

Fixed:
- 🐛(frontend) Fix the break line when generate PDF (#84)

Delete:
- 💚(CI) Remove trigger workflow on push tags on CI (#68)
- 🔥(frontend) Remove coming soon page (#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ User Identity
1 participant