Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kafka 3.9.0 #10812

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Nov 7, 2024

Type of change

  • Task

Description

This PR adds support for Kafka 3.9.0 and removes support for 3.7.0 and 3.7.1.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.45.0 milestone Nov 7, 2024
@scholzj scholzj requested a review from ppatierno November 7, 2024 02:42
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the add-support-for-kafka-3.9.0 branch from 86a003f to 5a905db Compare November 7, 2024 02:50
@scholzj
Copy link
Member Author

scholzj commented Nov 7, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Nov 7, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Nov 7, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Nov 8, 2024

/azp run zookeeper-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Nov 8, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left one question.

public static final String PREVIOUS_FORMAT_VERSION = "3.7";
public static final String PREVIOUS_PROTOCOL_VERSION = "3.7";
public static final String PREVIOUS_METADATA_VERSION = "3.7-IV4";
public static final String PREVIOUS_KAFKA_VERSION = "3.8.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 3.8.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not really matter. It just needs to be a previous minor.

@scholzj scholzj merged commit f73b508 into strimzi:main Nov 9, 2024
43 checks passed
@scholzj scholzj deleted the add-support-for-kafka-3.9.0 branch November 9, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0.45.0
Development

Successfully merging this pull request may close these issues.

2 participants