Upgrade to Next 12 and MUI 5 #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install mui 5.2 - Remove material-ui 4 - Replace peerDependencies - Upgrade minimum node version (in preparation for next)
Note: consider readjusting sizing values if necessary
Note: consider fixing accordion test manually, as it errored during codemod run
(For JSS => emotion migration)
(where codemods didn't work)
removeMakeStyels
Also: remove adaptV4Theme usage
- Match code styles from other commits - Ensure necessary variables are used/defined
- Update push-build command to use --sig and npm run build (over yarn) - Installed peer dependencies properly with npm8 - Update enzyme-adapter-react
- Ensure defaultClass.root is used over passed in classes.root for Carousel - Update thumbnails Tab wrapper usage - Fix spaces in selectors where necessary
- Migrate JSS selector code to styled for hovering => expand - Fix expand media query
- Added 'material-ui-popup-state' to manage hover/popup menus for main navigation - Updated NavTab to use the aforementioned library
|
is this task still in progress ? |
|
Going to fix the tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.