[5.x] Only apply the published filter when not in preview mode #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
requested changes
Apr 3, 2025
|
Sure, i'll setup a test for checking if draft entries are received with a token and omitted without a token. 👍 |
|
I've added the testcase. While running the test I also needed to fix a line where the filters would default to |
|
@duncanmcclean have you had a chance to review the changes? 😃 |
|
Sorry, I don't normally review PRs, beyond giving them a quick look over, so I don't have an ETA for when we'll review this pull request. In the meantime, you can pull this PR into your project with a composer patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for issue #6134
Checks if we're in
isLivePreviewbefore appending$filters['status'] = 'published';Works similar as the fix made for the REST API #10229