-
-
Notifications
You must be signed in to change notification settings - Fork 7
[Merged by Bors] - Support tls authentication #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for each client, client authentication and internal communication
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Starting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the tests. The number of tests exploded, but IMHO out of scope for this PR
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom tests took 13h and failed 🙈
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/9/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is green :)
bors merge |
# Description Implemented support for: - Client TLS (defaults to "tls") - Authenticated client TLS (optional) - Internal broker TLS (defaults to "tls) Sorry for the big PR :( closes #12 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Pull request successfully merged into main. Build succeeded: |
# Description Sorry forgot to add in this PR #442 Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Description
Implemented support for:
Sorry for the big PR :(
closes #12
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information