Skip to content

[Merged by Bors] - Support tls authentication #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 37 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Aug 3, 2022

Description

Implemented support for:

  • Client TLS (defaults to "tls")
  • Authenticated client TLS (optional)
  • Internal broker TLS (defaults to "tls)

Sorry for the big PR :(

closes #12

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team August 3, 2022 15:53
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sbernauer sbernauer removed the request for review from a team August 4, 2022 07:17
@maltesander maltesander requested a review from sbernauer August 4, 2022 12:29
@sbernauer
Copy link
Member

Starting review

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the tests. The number of tests exploded, but IMHO out of scope for this PR

@maltesander maltesander requested a review from sbernauer August 5, 2022 09:25
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbernauer
Copy link
Member

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is green :)

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 8, 2022
# Description

Implemented support for:
- Client TLS (defaults to "tls")
- Authenticated client TLS (optional)
- Internal broker TLS (defaults to "tls)

Sorry for the big PR :(

closes #12



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support tls authentication [Merged by Bors] - Support tls authentication Aug 8, 2022
@bors bors bot closed this Aug 8, 2022
@bors bors bot deleted the support_tls_authentication branch August 8, 2022 05:51
bors bot pushed a commit that referenced this pull request Sep 7, 2022
# Description

Sorry forgot to add in this PR #442



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS authentication with provided certificates
2 participants