Skip to content

Don't stop reconciling if one of the objects is not deserializable #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
17 tasks done
nightkr opened this issue Apr 21, 2022 · 8 comments
Closed
17 tasks done

Don't stop reconciling if one of the objects is not deserializable #211

nightkr opened this issue Apr 21, 2022 · 8 comments
Assignees
@lfrancke
Labels
customer-request release/24.11.0

Comments

@nightkr
Copy link
Member

nightkr commented Apr 21, 2022 •
edited
Loading

Currently our watchers break entirely if any object fails to deserialize. Ideally this should be confined to only affect the object in question.

The prerequisites have been done by fixing kube-rs and bringing the necessary changes into operator-rs. A sample implementation has also been done for NiFi, we now need to roll this out across the board.
@lfrancke lfrancke moved this to Ready for Development in Stackable Engineering Aug 5, 2024
@nightkr
Copy link
Member Author

nightkr commented Aug 5, 2024

Will discuss with upstream kube-rs (and maybe k8s-openapi?) on where to go from here.

@nightkr
Copy link
Member Author

nightkr commented Aug 8, 2024 •
edited
Loading

kube-rs/kube#1556 is merged, we should be able to trial-migrate an operator to DeserializeGuard<K>. A merge and full rollout should wait until there is a new release of kube-rs with it.

This was referenced Aug 8, 2024
Closed
Merged
@nightkr
Copy link
Member Author

nightkr commented Aug 12, 2024

Trial PR: stackabletech/nifi-operator#662

@sbernauer sbernauer moved this from Development: Track to Development: In Progress in Stackable Engineering Sep 9, 2024
@sbernauer
Copy link
Member

https://github.com/kube-rs/kube/releases/tag/0.94.0 released

@nightkr nightkr moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 2, 2024
@nightkr
Copy link
Member Author

nightkr commented Oct 2, 2024

The Nifi-Operator PR has now been updated to use the release builds.

@nightkr
Copy link
Member Author

nightkr commented Oct 8, 2024

Nifi-Operator PR is merged, ready for wider rollout.

@nightkr nightkr moved this from Development: Waiting for Review to Ready for Development in Stackable Engineering Oct 8, 2024
@nightkr nightkr removed their assignment Oct 8, 2024
@lfrancke lfrancke changed the title Provide some way to defer Serde errors in watchers Don't stop reconciling if one of the objects is not deserializable Oct 16, 2024
@razvan razvan mentioned this issue Oct 22, 2024
Merged
nightkr added a commit to stackabletech/opa-operator that referenced this issue Oct 22, 2024
@nightkr
Migrate to DeserializeGuard
9f3e992 
Part of stackabletech/issues#211
@nightkr nightkr mentioned this issue Oct 22, 2024
Merged
@razvan razvan mentioned this issue Oct 22, 2024
Merged
nightkr added a commit to stackabletech/listener-operator that referenced this issue Oct 22, 2024
@nightkr
Migrate to DeserializeGuard
9c257ed 
Part of stackabletech/issues#211
@nightkr nightkr mentioned this issue Oct 22, 2024
Merged
github-merge-queue bot pushed a commit to stackabletech/opa-operator that referenced this issue Oct 22, 2024
@nightkr
Migrate to DeserializeGuard (#638)
1db5db4 
* Migrate to DeserializeGuard

Part of stackabletech/issues#211

* Changelog
@razvan razvan mentioned this issue Oct 22, 2024
Merged
github-merge-queue bot pushed a commit to stackabletech/listener-operator that referenced this issue Oct 22, 2024
@nightkr
Migrate to DeserializeGuard (#238)
db1947f 
* Migrate to DeserializeGuard

Part of stackabletech/issues#211

* Changelog
This was referenced Oct 23, 2024
Merged
Merged
nightkr added a commit to stackabletech/zookeeper-operator that referenced this issue Oct 23, 2024
@nightkr
Migrate to DeserializeGuard
3f25f5d 
Part of stackabletech/issues#211
@nightkr nightkr mentioned this issue Oct 23, 2024
Merged
github-merge-queue bot pushed a commit to stackabletech/zookeeper-operator that referenced this issue Oct 23, 2024
@nightkr
Migrate to DeserializeGuard (#872)
cae173e 
* Migrate to DeserializeGuard

Part of stackabletech/issues#211

* Changelog
@razvan razvan mentioned this issue Oct 23, 2024
Merged
nightkr added a commit to stackabletech/commons-operator that referenced this issue Oct 23, 2024
@nightkr
Migrate to DeserializeGuard
26e8695 
Some cases have been migrated to PartialObjectMeta instead where only
the metadata is used anyway.

Part of stackabletech/issues#211. Fixes #237.
@nightkr nightkr mentioned this issue Oct 23, 2024
Merged
This was referenced Oct 23, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit to stackabletech/commons-operator that referenced this issue Oct 24, 2024
@nightkr
Migrate to DeserializeGuard (#293)
ee83f52 
* Migrate to DeserializeGuard

Some cases have been migrated to PartialObjectMeta instead where only
the metadata is used anyway.

Part of stackabletech/issues#211. Fixes #237.

* Changelog

* Avoid requesting CM/secret data entirely

Instead of requesting it but throwing it away.
@razvan razvan mentioned this issue Oct 24, 2024
Merged
@nightkr
Copy link
Member Author

nightkr commented Oct 24, 2024

Aaand that should be all of them, nice!

@nightkr nightkr closed this as completed Oct 24, 2024
@lfrancke
Copy link
Member

Great work! Thank you!

@nightkr nightkr mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfrancke lfrancke

Labels
customer-request release/24.11.0
Projects
Stackable End-to-End Coordination
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lfrancke @nightkr @maltesander @sbernauer