-
Notifications
You must be signed in to change notification settings - Fork 122
DOC: fix bug in custom StacIO example #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 94.31% // Head: 94.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 80 80
Lines 11923 11923
Branches 1130 1130
=======================================
Hits 11245 11245
Misses 496 496
Partials 182 182 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are a lot of formatting changes to the CHANGELOG included in this PR. They all look good to me, so I'm fine with including them.
@martinfleis Do you have some kind of linter that you ran on that file to generate those changes?
Ah, sorry about that! Yes, that is gonna be caused by |
Description:
There is a bug in documentation in an example of a custom
StacIO
class caused by a mismatch of argument and variable names. This PR fixes it.PR Checklist: