Skip to content

stac_io as argument to Catalog.save #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Conversation

fnattino
Copy link
Contributor

@fnattino fnattino commented Feb 19, 2022

Related Issue(s):

Closes #666

Description:
Add the possibility of providing a StacIO instance to write out a catalog, as useful e.g. to read from and write to different file systems.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #751 (64042bc) into main (8b8ad7e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.02%     
==========================================
  Files          77       77              
  Lines       11298    11312      +14     
  Branches     1343     1346       +3     
==========================================
+ Hits        10665    10681      +16     
+ Misses        455      453       -2     
  Partials      178      178              
Impacted Files Coverage Δ
pystac/catalog.py 92.15% <100.00%> (ø)
tests/test_catalog.py 99.00% <100.00%> (+0.01%) ⬆️
tests/utils/stac_io_mock.py 92.59% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8ad7e...64042bc. Read the comment docs.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @fnattino !

@duckontheweb duckontheweb merged commit e2bf1d5 into stac-utils:main Feb 22, 2022
@fnattino fnattino deleted the fix/666 branch February 22, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a stac_io argument in Catalog.save?
3 participants