Use type alias for temporal intervals #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @cuttlefish |
Codecov Report
@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage 94.33% 94.34%
=======================================
Files 77 77
Lines 11285 11291 +6
Branches 1347 1347
=======================================
+ Hits 10646 10652 +6
Misses 459 459
Partials 180 180
Continue to review full report at Codecov.
|
gadomski
approved these changes
Feb 3, 2022
duckontheweb
added a commit
to duckontheweb/pystac
that referenced
this pull request
Feb 3, 2022
gadomski
approved these changes
Feb 3, 2022
duckontheweb
force-pushed
the
fix/586-temporal-interval-typing
branch
from
0a026b4 to
696cfc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adds 2 type variables that are used in the
TemporalExtentclass:TemporalIntervals- This is used for properly formatted STAC temporal intervals (i.e. a list of lists)TemporalIntervalsLike- This is used for theintervalsargument toTemporalExtentwhere we allow either a list of lists or a list of optional datetimes and convert it into a list of lists.I tried using a covariant
TypeVaras I had initially suggested in #586 (comment), but that did not fix the type errors. Using aUniontype of all the possible combinations seemed to be the only way to makemypyhappy.Also note that this adds a test whose only purpose is type checking when we run
mypy. If there are suggestions on a better place to put this kind of check I'm happy to change that.PR Checklist:
pre-commit run --all-files)scripts/test)