Skip to content

Fix paths to saved sub-catalogs #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jan 15, 2022

Related Issue(s):

Description:

Fixes the paths to which sub-catalogs are saved by ensuring that the dest_href argument to Catalog.save is a directory when called on child catalogs.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from gadomski January 15, 2022 11:51
@duckontheweb duckontheweb added this to the 1.3.0 milestone Jan 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #714 (a0c3e41) into main (70faaa5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   94.30%   94.31%           
=======================================
  Files          77       77           
  Lines       11249    11268   +19     
  Branches     1342     1344    +2     
=======================================
+ Hits        10608    10627   +19     
  Misses        461      461           
  Partials      180      180           
Impacted Files Coverage Δ
pystac/catalog.py 92.13% <100.00%> (ø)
tests/test_catalog.py 98.96% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70faaa5...a0c3e41. Read the comment docs.

@duckontheweb
Copy link
Contributor Author

cc: @KennSmithDS

@duckontheweb duckontheweb merged commit b136f25 into stac-utils:main Jan 18, 2022
@duckontheweb duckontheweb deleted the fix/713-sub-catalog-save-paths branch January 18, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect path to saved sub-catalogs
3 participants