Skip to content

Add note on possible exceptions to extensions docs #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jan 7, 2022

Related Issue(s):

Description:

Adds a note to the Concepts docs describing how to access extension properties that makes it more clear that .ext will raise an exception if the object does not already implement the extension.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb added this to the 1.3.0 milestone Jan 7, 2022
@duckontheweb duckontheweb requested a review from lossyrob January 7, 2022 01:43
duckontheweb added a commit to duckontheweb/pystac that referenced this pull request Jan 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #701 (f2408e8) into main (ddafad4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          77       77           
  Lines       11249    11249           
  Branches     1342     1342           
=======================================
  Hits        10608    10608           
  Misses        461      461           
  Partials      180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddafad4...f2408e8. Read the comment docs.

@alexgleith
Copy link

I think that looks good! Thanks :-)

duckontheweb added a commit to duckontheweb/pystac that referenced this pull request Jan 14, 2022
@duckontheweb duckontheweb force-pushed the fix/602-concepts-ext-docs branch from ed47631 to 5d3ea79 Compare January 14, 2022 15:08
@duckontheweb duckontheweb force-pushed the fix/602-concepts-ext-docs branch from 5d3ea79 to f2408e8 Compare January 14, 2022 16:49
@duckontheweb duckontheweb merged commit 61d8c60 into stac-utils:main Jan 14, 2022
@duckontheweb duckontheweb deleted the fix/602-concepts-ext-docs branch January 14, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants