Skip to content

Reformat docs and move to PyData sphinx theme #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 17, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Dec 19, 2021

Related Issue(s):

Description:

This changes the Sphinx theme for our docs from alabaster to the PyData Sphinx Theme as suggested in #635. Additionally, it makes some changes to the layout and structure of the docs to (hopefully) make them a bit more user-friendly, especially for newcomers. The layout changes were based heavily on the Bokeh documentation. Those docs are one of the examples for the PyData Sphinx Theme, and to my eye they provide a really clear landing page that helps direct different audiences to the right place in the docs.

I had also always found the API docs to be hard to navigate, especially as the codebase grew larger. I reworked those docs so that the API Reference has a landing page with cards organized by topics (either related to STAC or PySTAC) and a table of contents organized by module.

I am opening as a Draft while I get the docs to build on Sphinx as an example, and would love to get some feedback on the theme change, the high-level changes to the structure, and the API Reference changes. Updating some of the tutorials that are still out of date (e.g. #602) will be covered in separate PRs.

Preview of the new docs is available at https://pystac--687.org.readthedocs.build/en/687/.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb changed the title Change/635 docs formatting Reformat docs and move to PyData sphinx theme Dec 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #687 (65491b6) into main (70faaa5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          77       77           
  Lines       11249    11250    +1     
  Branches     1342     1342           
=======================================
+ Hits        10608    10609    +1     
  Misses        461      461           
  Partials      180      180           
Impacted Files Coverage Δ
pystac/extensions/item_assets.py 84.44% <ø> (ø)
pystac/item.py 91.05% <ø> (ø)
pystac/link.py 90.85% <ø> (ø)
pystac/stac_object.py 90.81% <ø> (ø)
pystac/catalog.py 92.15% <100.00%> (+0.01%) ⬆️
pystac/collection.py 94.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70faaa5...65491b6. Read the comment docs.

@duckontheweb duckontheweb force-pushed the change/635-docs-formatting branch from 4347dfc to 2829a5b Compare January 4, 2022 14:46
duckontheweb added a commit that referenced this pull request Jan 4, 2022
@duckontheweb duckontheweb added this to the 1.3.0 milestone Jan 4, 2022
@duckontheweb duckontheweb requested a review from gadomski January 11, 2022 16:47
@duckontheweb
Copy link
Contributor Author

@KennSmithDS @alexgleith @robintw @yeelauren You all have raised documentation-related issues in the past, so I thought I'd bring this to your attention. Let me know if any of you have any feedback on the new format/theme. Thanks!

@KennSmithDS
Copy link
Contributor

KennSmithDS commented Jan 11, 2022

@duckontheweb overall I love the changes so far, the theme is very clean and a lot easier to find the information I'm looking for. Here are some bulleted thoughts:

  • Bokeh inspired boostrap theme is way more visually appealing than the old look and feel which kinda hurt my eyes
  • Navigating and searching for content has dramatically improved, especially the side panel when browsing API reference
  • The code snippets (especially for tutorials) are significantly easier on the eyes to read through example code and spot dependencies
  • SUGGESTION: might want to put the STAC logo on the left-most side of the top navbar?

@duckontheweb
Copy link
Contributor Author

  • SUGGESTION: might want to put the STAC logo on the left-most side of the top navbar?

Yes, good idea. I considered doing this and then wasn't sure if I should use the STAC logo or if there was another one that was more specific to PySTAC. @lossyrob @cholmes Do you know if we have any PySTAC-specific logos?

@lossyrob
Copy link
Member

There's no specific PySTAC logo - I once made one that was just the STAC logo but with the globe replaced by the Python logo. I'm not actually sure this is copacetic wrt the Python logo usage rules. I think adding the general STAC logo would be appropriate.

@duckontheweb duckontheweb force-pushed the change/635-docs-formatting branch from a1e973a to 6f70037 Compare January 14, 2022 21:24
@duckontheweb
Copy link
Contributor Author

Added the STAC logo in 65491b6. I'll plan on merging this today unless there is any last-minute feedback.

@alexgleith
Copy link

Looks great. Clean and pretty. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sphinx theme
6 participants