Skip to content

Add migration for eo:epsg to proj:epsg #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 14, 2021

Related Issue(s):

Description:

Adds migration for eo:epsg to proj:epsg for pre-0.9 catalogs.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob July 14, 2021 02:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #557 (097f4b5) into main (660fd9a) will decrease coverage by 0.01%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   94.50%   94.48%   -0.02%     
==========================================
  Files          71       71              
  Lines       10703    10725      +22     
  Branches     1095     1098       +3     
==========================================
+ Hits        10115    10134      +19     
- Misses        418      419       +1     
- Partials      170      172       +2     
Impacted Files Coverage Δ
pystac/extensions/eo.py 93.30% <70.00%> (-1.12%) ⬇️
tests/extensions/test_eo.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660fd9a...097f4b5. Read the comment docs.

@lossyrob
Copy link
Member

Was surprised to see this not accounted for...

+1 besides including a test to show it works - there's likely already a migrated example in the 0.9 example test files

@duckontheweb
Copy link
Contributor Author

+1 besides including a test to show it works

Added in ea2ef92

@duckontheweb duckontheweb force-pushed the add/gh-262-epsg-migration branch from ea2ef92 to 8c9ecb4 Compare July 15, 2021 15:09
@duckontheweb duckontheweb merged commit b8853d3 into stac-utils:main Jul 16, 2021
@duckontheweb duckontheweb deleted the add/gh-262-epsg-migration branch July 17, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants