Skip to content

Update Timestamps Extension #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 3, 2021

Related Issue(s):

Description:

  • Update docstring and adds Summaries for Timestamps Extension
  • Defines equality and __repr__ for RangeSummary (cherry picked from Update Satellite Extension #509, so there should be no conflict)

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob July 3, 2021 18:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #513 (4870116) into main (a4fe4cd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   93.96%   94.03%   +0.07%     
==========================================
  Files          71       71              
  Lines        9991    10076      +85     
  Branches     1061     1068       +7     
==========================================
+ Hits         9388     9475      +87     
+ Misses        434      432       -2     
  Partials      169      169              
Impacted Files Coverage Δ
pystac/extensions/eo.py 94.33% <ø> (ø)
pystac/extensions/timestamps.py 100.00% <100.00%> (+2.89%) ⬆️
pystac/summaries.py 76.72% <100.00%> (+0.91%) ⬆️
tests/extensions/test_timestamps.py 100.00% <100.00%> (ø)
tests/test_summaries.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fe4cd...4870116. Read the comment docs.

@duckontheweb duckontheweb merged commit 0432554 into stac-utils:main Jul 7, 2021
@duckontheweb duckontheweb deleted the update/timestamps-extension branch July 7, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants