Skip to content

Add Label Extension summaries #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 28, 2021

Related Issue(s):

Description:

  • Defines equality for component classes in the Label Extension (e.g. LabelClasses, LabelProperties, etc.)
  • Adds summaries for fields defined in stac-fields
  • Uses Enum for "label:tasks", but continues to allow free string input (following pattern for RelType).

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb changed the title add/label-ext-summaries Add Label Extension summaries Jun 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #484 (4997826) into main (f742fa4) will increase coverage by 0.04%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   91.66%   91.71%   +0.04%     
==========================================
  Files          40       40              
  Lines        5245     5310      +65     
==========================================
+ Hits         4808     4870      +62     
- Misses        437      440       +3     
Impacted Files Coverage Δ
pystac/extensions/label.py 96.30% <95.65%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f742fa4...4997826. Read the comment docs.

@duckontheweb duckontheweb force-pushed the add/label-ext-summaries branch from 2fe6f6d to c99a54b Compare June 29, 2021 17:44
@duckontheweb duckontheweb merged commit c0f0b6d into stac-utils:main Jun 29, 2021
@duckontheweb duckontheweb deleted the add/label-ext-summaries branch June 29, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants