Skip to content

Experimental Python 3.10 support #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 24, 2021

Related Issue(s):

Description:

Adds Python 3.10 to the test matrix, but allows the CI workflow to succeed even if any Python 3.10 job fails. The main hiccup is that orjson does not have Python 3.10 wheels for Windows or MacOS, and needs the Rust nightly toolchain to build. The CI job installs Rust nightly for Python 3.10 jobs, and this PR adds a note in the Installation docs describing this requirements.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2021

Codecov Report

Merging #473 (40f16a5) into main (13a9fad) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   91.48%   91.66%   +0.17%     
==========================================
  Files          40       40              
  Lines        5240     5245       +5     
==========================================
+ Hits         4794     4808      +14     
+ Misses        446      437       -9     
Impacted Files Coverage Δ
pystac/__init__.py 100.00% <0.00%> (ø)
pystac/errors.py 90.00% <0.00%> (+1.11%) ⬆️
pystac/stac_io.py 82.75% <0.00%> (+5.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a9fad...40f16a5. Read the comment docs.

@duckontheweb
Copy link
Contributor Author

cc: @l0b0

@duckontheweb duckontheweb merged commit 164a990 into stac-utils:main Jun 29, 2021
@duckontheweb duckontheweb deleted the add/python-3_10 branch June 29, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants