Skip to content

Add args/kwargs to StacIO.read_json #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 11, 2021

Related Issue(s): #

Description:

Adds *args and **kwargs parameters to StacIO.read_json and passes them to StacIO.read_text.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #433 (14522fc) into main (8946c9b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          39       39           
  Lines        5115     5115           
=======================================
  Hits         4581     4581           
  Misses        534      534           
Impacted Files Coverage Δ
pystac/stac_io.py 72.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8946c9b...14522fc. Read the comment docs.

@duckontheweb duckontheweb merged commit dabade7 into stac-utils:main Jun 11, 2021
@duckontheweb duckontheweb deleted the fix/411-read_json-args branch June 11, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StacIO.read_json should accept *args and **kwargs
3 participants