Skip to content

Add more pointcloud extension tests #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2021
Merged

Add more pointcloud extension tests #352

merged 2 commits into from
May 24, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 21, 2021

Related Issue(s): #248

Description: Increase coverage for pointcloud extension tests. Doesn't go 100% b/c I don't like testing __repr__ and there's some property getter paths that don't seem worth exploring because they seem like they're already protected in one of the superclasses.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #352 (3e2d51c) into main (016e56c) will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   88.59%   89.43%   +0.84%     
==========================================
  Files          36       36              
  Lines        4629     4629              
==========================================
+ Hits         4101     4140      +39     
+ Misses        528      489      -39     
Impacted Files Coverage Δ
pystac/extensions/pointcloud.py 96.61% <0.00%> (+16.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016e56c...3e2d51c. Read the comment docs.

@lossyrob
Copy link
Member

LGTM - @duckontheweb I'll leave it to you to merge this, as it will effect the total code coverage in a potentially disruptive way if you are tracking it as part of #331

@duckontheweb
Copy link
Contributor

LGTM - @duckontheweb I'll leave it to you to merge this, as it will effect the total code coverage in a potentially disruptive way if you are tracking it as part of #331

Sounds good. I'm going to go ahead and merge since the changes are all positive and pretty isolated, but thanks for checking.

@duckontheweb duckontheweb merged commit c7d845f into stac-utils:main May 24, 2021
@gadomski gadomski deleted the fix/issues/248-pointcloud-test-coverage branch May 24, 2021 13:30
l0b0 pushed a commit to l0b0/pystac that referenced this pull request May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants