Skip to content

Execute the validate method in tests #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021
Merged

Execute the validate method in tests #346

merged 2 commits into from
May 18, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 17, 2021

Related Issue(s): #339

Description: There were a few instances in the test suite where we wanted to validate an item, but the method wasn't actually called.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4c7c775). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage        ?   88.60%           
=======================================
  Files           ?       36           
  Lines           ?     4625           
  Branches        ?        0           
=======================================
  Hits            ?     4098           
  Misses          ?      527           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7c775...295907f. Read the comment docs.

@lossyrob lossyrob merged commit 52f3641 into stac-utils:main May 18, 2021
@gadomski gadomski deleted the issues/339-validate-in-tests branch May 18, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants