Add catalog_type to Catalog to track catalog type of read STACs. #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
force-pushed
the
feature/rde/catalog_type
branch
from
0379518 to
1728d71
Compare
Codecov Report
@@ Coverage Diff @@
## develop #224 +/- ##
===========================================
+ Coverage 93.19% 93.20% +0.01%
===========================================
Files 29 29
Lines 3557 3577 +20
===========================================
+ Hits 3315 3334 +19
- Misses 242 243 +1
Continue to review full report at Codecov.
|
Before this change, the save method on Catalog always requires a CatalogType supplied as an argument. This change determines the catalog type of a catalog that is read in by examining its Links and carries that information on the object, so that if a catalog_type is set on the catalog, it does not need to be supplied as an argument for the save call.
lossyrob
force-pushed
the
feature/rde/catalog_type
branch
from
1728d71 to
11e03fb
Compare
lossyrob
added a commit
that referenced
this pull request
Oct 29, 2020
As a follow-up to #224, set the catalog_type in Collection.to_dict similar to how it is set in Catalog.to_dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a catalog_type as an attribute to Catalog. This is determined when reading in a catalog through inspecting the links.
Before this change, the save method on Catalog always requires a CatalogType supplied as an argument. This change determines the catalog type of a catalog that is read in by examining its Links and carries that information on the object, so that if a catalog_type is set on the catalog, it does not need to be supplied as an argument for the save call.
This is useful for users who want to read in a catalog, make a change (say, add some items), and save back the catalog, without having to think about what the original catalog type was.