Refactor caching to utilize HREFs and parent IDs #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
force-pushed
the
feature/rde/href-caching
branch
from
635df33 to
3ce9d5c
Compare
This commit modifies the caching strategy of PySTAC away from being based simply on the ID of the STACObject. This can cause issues as STAC objects do not necessarily have unique IDs, though best practices say unique IDs are prefered. This change modifies the cache to be based off of the self HREF first, and if none is present, based off of not just the object's ID but the ID of all of it's parents. The caching is updated any time set_self_href is called on a STAC object so the cache is kept up-to-date when new HREFs are set on objects. Fixes #92
lossyrob
force-pushed
the
feature/rde/href-caching
branch
from
3ce9d5c to
7bbe8f7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #214 +/- ##
===========================================
+ Coverage 92.36% 92.59% +0.23%
===========================================
Files 28 28
Lines 3351 3375 +24
===========================================
+ Hits 3095 3125 +30
+ Misses 256 250 -6
Continue to review full report at Codecov.
|
lossyrob
added a commit
that referenced
this pull request
Oct 28, 2020
This change was missed in #214. In that PR, the set_self_href logic that existed on Collection was promoted to be the logic of all set_self_hrefs on STACObjects. This makes this method unnecessary, and causes duplicate calls to cache logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the caching strategy used by the resolved object cache to be based on an object's self HREF if available, and if not, to use a combination of the object's and its parents' IDs.
Before this change PySTAC required IDs to be unique within a catalog. This proved to be too restrictive and produced unexpected results in several situations.
Fixes #160
Fixes #92