Skip to content

Codespell 20201013 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Codespell 20201013 #195

merged 2 commits into from
Oct 15, 2020

Conversation

schwehr
Copy link
Collaborator

@schwehr schwehr commented Oct 13, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #195 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #195   +/-   ##
========================================
  Coverage    91.81%   91.81%           
========================================
  Files           27       27           
  Lines         3225     3225           
========================================
  Hits          2961     2961           
  Misses         264      264           
Impacted Files Coverage Δ
pystac/extensions/single_file_stac.py 92.53% <ø> (ø)
pystac/validation/stac_validator.py 92.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e56606...8e9b16b. Read the comment docs.

Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, much needed.

One way to prevent such horrible misspellings (all of them mine) in the future is to run codespell as part of CI testing. Any ignore words could be put into an ignore file that we also commit. Any thoughts on that? I wrote up an issue on that in #200, so we can chat about it there. Merging this now.

@lossyrob lossyrob merged commit 9944c51 into stac-utils:develop Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants