Skip to content

fix: don't set code for None epsg #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025
Merged

fix: don't set code for None epsg #1544

merged 4 commits into from
Apr 4, 2025

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 4, 2025

Related Issue(s):

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell April 4, 2025 06:00
@gadomski gadomski self-assigned this Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (4dc0e0f) to head (abc32fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
- Coverage   91.62%   91.62%   -0.01%     
==========================================
  Files          54       54              
  Lines        7580     7578       -2     
  Branches      923      923              
==========================================
- Hits         6945     6943       -2     
  Misses        451      451              
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one! Just one suggestion.

Co-authored-by: Julia Signell <jsignell@gmail.com>
@gadomski
Copy link
Member Author

gadomski commented Apr 4, 2025

Agreed, I missed the delete, thanks.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gadomski gadomski added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit e713adf Apr 4, 2025
19 checks passed
@gadomski gadomski deleted the issues/1543-none-epsg branch April 4, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projection Extension migrate doesn't handle "proj:epsg": None case correctly
2 participants